Port GraalVM reachability to 3.x #3884
Merged
+1,562
−273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors and updates PluginProcessor to function more similarly to GraalVmProcessor. This re-uses the recently added PluginIndex class for tracking processed plugins before dumping this data in the final annotation processing round.
This ports the GraalVmProcessor introduced in a14f0ad (released in 2.25.0) to the plugin model of 3.x.
jvz
added
plugins
ppkarwasz
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
Hi @jvz,
Thanks for the contribution, and sorry for the delay. The PR looks good overall, but I noticed it includes some unrelated changes. Could you please separate those into a different PR? It helps keep the history cleaner and makes reviews easier.
log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/model/PluginRegistry.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3055 by porting #3053. I've ported the annotation processor from 2.x and did some refactoring of the other annotation processor to work more like this new one.